On Wed, 8 Jan 2025 20:29:03 GMT, Christian Stein <cst...@openjdk.org> wrote:

>> Please review this change request enabling native access in source launch 
>> mode when using a modular setup.
>> 
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted from module bootstrap 
>> for user module not being present in the boot layer: `java.c` and 
>> `ModuleBootstrap.java`
>> 2. Enable native access in source module(s) and also user modules on the 
>> module path as requested by `--enable-native-access` via the 
>> `ModuleLayer.Controller` API - and emit warning for unknown modules: 
>> `MemoryContext.java`
>> 
>> _Testing of tier1..3 is in progress..._
>
> Christian Stein has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Ignore already handled `ALL-UNNAMED` name

The handling of the new option seems correct:
* `ALL-UNNAMED` is already handled by module bootstrap, so left alone
* source modules are correctly handled
* `illegal-native-access` is a runtime option, so again, not handled (which is 
ok)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22930#issuecomment-2586824078

Reply via email to