On Thu, 9 Jan 2025 16:47:18 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in > src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an > implementation that was shared between Solaris and AIX. Linux and MacOS > already had specific implementations. After the removal of the Solaris port, > these two functions can be removed in favor of inline implementations of > os_getParentPidAndTimings and os_getCmdlineAndUserInfo in > src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c. Looks good, but I have a few requests/suggestions: 1. Please update the copyright years 2. In ProcessHandleImpl_aix.c you could add an SAP copyright line 3. In line 57 of src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c there is another mentioning of Solaris which could be removed 4. On the same lines you could get rid of unix_getChildren in src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c and move the implementation to os_getChildren in src/java.base/linux/native/libjava/ProcessHandleImpl_linux.c ------------- Changes requested by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23013#pullrequestreview-2541585572
