On Thu, 19 Dec 2024 16:48:33 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> Please review this doc-only patch to fix an issue that causes the > cmp-baseline build to fail. > > The snippet in `LabelTrget.java` showed a highly rare non deterministism in > javadoc snippet generation, which will be fixed in > [JDK-8346659](https://bugs.openjdk.org/browse/JDK-8346659), but we can fix > the snippet now to stop the failures. > > Previously, "label" in "labelBinding" would be matched to either > `CodeBuilder#labelBinding` or `LabelTarget#label` (about 50:50 chance of > either happening). I repaced the substring with a regex which seems to fix > the issue. > > This will need to be backported to JDK 24. > > TIA! Positive lookahead (regex) that you used is a good way to fix this particular issue. Previous markup matched the same string region by two different links. That created an ambiguity, which was resolved at random. ------------- Marked as reviewed by prappo (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22834#pullrequestreview-2516313402
