On Thu, 19 Dec 2024 12:38:27 GMT, liyazzi <d...@openjdk.org> wrote: >> For two cases: >> >> 1. When the ImageReaderFactory was loaded by local jdk,that means the >> ImageReaderFactory was loaded by boot class loader,then init the `Path >> BOOT_MODULES_JIMAGE` by using `sun.nio.fs.DefaultFileSystemProvider` which >> is obtained through reflection,due to it is in jdk internal. >> 2. When loaded by a target jdk, such as jdk8 runtime, then use the Java 8 >> compatible APIs: `FileSystems.getDefault()` to init the >> `BOOT_MODULES_JIMAGE` field. >> Then we can avoid the circular dependencies in class loading caused by >> loading the defaultSystemProvider. > > liyazzi has updated the pull request incrementally with two additional > commits since the last revision: > > - Update the date of 'ImageReaderFactory' > - Update the date of 'ImageReaderFactory' and remove the import of > 'Disabled' in SetDefaultProvider test
The changes in this PR which are backed by the discussions in https://github.com/openjdk/jdk/pull/21997 look fine to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22628#pullrequestreview-2515326776
