> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which > sounds redundant, just say "expected not equals but was 12345". > > `Asserts.assertEqualsByteArray` uses the words "expected... to equal...". > Modify it to follow the `assertEquals` style ""expected... but was...".
Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into 8340493 - rename to expected, unexpected, and actual - the fix ------------- Changes: - all: https://git.openjdk.org/jdk/pull/21101/files - new: https://git.openjdk.org/jdk/pull/21101/files/96696a09..5c5c2a3a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21101&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21101&range=00-01 Stats: 799550 lines in 10314 files changed: 516390 ins; 222605 del; 60555 mod Patch: https://git.openjdk.org/jdk/pull/21101.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21101/head:pull/21101 PR: https://git.openjdk.org/jdk/pull/21101