On Mon, 9 Dec 2024 13:59:29 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> @eme64 Yes I have thought about that. My idea is that once phase lowering is >> ready we will move the expansion there (#21599) . This removes the need to >> have a standalone method that checks if `LoadShuffleNode` is needed. The >> current situation is that `VectorRearrangeNode` is expected to come with >> `VectorLoadShuffleNode` so you cannot easily work with >> `VectorRearrangeNode`, either. > > @merykitty Ok. Is there a chance we could wait for that additional phase to > arrive then, and only do this refactor here afterward? I'd also be ok with a > follow up RFE - it would just have to be filed and be clear who will take > care of it ;) @eme64 I think this PR is orthogonal to the concern you are having. Either we need to refactor the expansion to lowering, then modify this PR to match the semantics, or we integrate this PR first, then do the lowering refactor on the resulting code. I would prefer the latter then I can take the task to move `VectorLoadShuffle` creation to lowering afterwards. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21042#issuecomment-2528080973
