On Wed, 4 Dec 2024 14:06:38 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Disable IR tests on IA32 > > test/hotspot/jtreg/compiler/c2/irTests/TestFPConversion.java line 33: > >> 31: * @summary Test that code generation for FP conversion works as intended >> 32: * @library /test/lib / >> 33: * @requires os.arch != "x86" & os.arch != "i386" > > It would have been preferrable to add this to the IR rule, so the test still > runs elsewhere. > What about `aarch64`? For all practical purposes, the test will run everywhere, really. It would be skipped only on `IA32`, which is going away. This `@requires` serves as the concession to `IA32` that is still in the tree. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22446#discussion_r1869679943
