On Wed, 4 Dec 2024 01:51:06 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update java.md >> >> [skip ci] > > src/java.base/share/man/java.md line 3077: > >> 3075: >> 3076: - The launcher doesn't expand wildcards that are present within an >> argument >> 3077: file. That means an asterisk `*` is passed on as-is to the >> starting VM. > > Suggestion: > > file. That means an asterisk (`*`) is passed on as-is to the starting VM. Addressed this and the other one in https://github.com/openjdk/jdk/pull/22236/commits/de0ac7c9676e405158c375f469ce1157bdc6f033 > src/java.base/share/man/java.md line 3079: > >> 3077: file. That means an asterisk `*` is passed on as-is to the >> starting VM. >> 3078: For example `*.java` stays `*.java` and is not expanded to >> `Foo.java`, >> 3079: `Bar.java ...`, as would happen with some command line shells. > > The list was intended to be contiguous - no commas: 'Foo.java Bar.java ...' > as that is how it would be expanded by the shell. Addressed this and the other one in https://github.com/openjdk/jdk/pull/22236/commits/de0ac7c9676e405158c375f469ce1157bdc6f033 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22236#discussion_r1869108834 PR Review Comment: https://git.openjdk.org/jdk/pull/22236#discussion_r1869108977
