On Mon, 25 Nov 2024 08:02:55 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
> Wow, thanks for tackling this! > > Ok, lots of style comments. > > But again: I would have loved to see this split up into these parts: > > * Scalar > * Scalar optimizations (value, ideal, identity) > * Vector > > This will again take many many week to get reviewed because it is a 3k+ > change with lots of details. > > Do you have any tests for the scalar constant folding optimizations? I did > not find them. Hey @eme64 , The patch includes IR framework-based scalar constant folding test points. https://github.com/openjdk/jdk/blob/5f58eea62a0f4d2cd731242a0fb264316ff5000d/test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.java#L170 Regarding vector operation inferencing, we are taking the standard route by adding new Vector IR and associated VectorNode::Opcode / making routine changes without changing the auto-vectorization core. Each new vector operation is backed by IR framework-based tests. https://github.com/openjdk/jdk/pull/21490/files#diff-30af2f4d6a92733f58967b0feab21ddbc58a8f1ac5d3d5660c0f60220f6fab0dR40 Our target is to get this integrated before JDK24-RDP1, your help and reviews will be highly appreciated. Best Regards ------------- PR Comment: https://git.openjdk.org/jdk/pull/21490#issuecomment-2497192437
