On Sat, 23 Nov 2024 17:27:43 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Quan Anh Mai has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> sharpen the return types of various FFM internal methods > > I see this patch is in 2 parts: > 1. Move of `AbstractMemorySegmentImpl::sessionImpl` to `scope` (a covariant > override). This involves a lot of usage updates. > 2. More specific return types for many other methods. > > Should these 2 be in 2 patches, as 1 has a lot of renaming changes? @liach Yes you are right, I have reverted the `scope` cleanup part. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22344#issuecomment-2495555588
