On Tue, 29 Oct 2024 18:01:55 GMT, Naoto Sato <na...@openjdk.org> wrote:

> Updates the JDK to use the latest Unicode 16.0.0, which also updates the 
> ICU4J along with it (8319992: Update ICU4J to Version 76.1). The 
> corresponding CSR has already been approved.

Marked as reviewed by jlu (Committer).

src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 38:

> 36:      * See Unicode Standard Annex #29 Unicode Text Segmentation for the 
> specification
> 37:      * for the extended grapheme cluster boundary rules. The following 
> implementation
> 38:      * is based on the annex for Unicode version 15.1.

Could bump the version 15.1 to 16.0

src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 272:

> 270:             //  Kirat Rai vowel sign
> 271:             if (cp >= 0xD7B0 && cp <= 0xD7C6 ||
> 272:                 cp == 0x16D63 ||

LGTM as this matches up with 
https://www.unicode.org/reports/tr29/tr29-45.html#V and the `case 0x113D1:` 
lines up with _TULU-TIGALARI REPHA_.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21771#pullrequestreview-2450437524
PR Review Comment: https://git.openjdk.org/jdk/pull/21771#discussion_r1851471389
PR Review Comment: https://git.openjdk.org/jdk/pull/21771#discussion_r1852722645

Reply via email to