On Sat, 16 Nov 2024 15:57:28 GMT, Attila Szegedi <att...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply review comments: >> Retain public static constants for permission names to avoid source/binary >> compatible changes that affect cross version use. >> Remove obsolete mention of security considerations. >> (The protected constructor is retained to avoid changing the access for >> subclass use) > > Hey Roger, thanks for doing this no doubt unglamorous maintenance task. I > reviewed it, and it mostly looks good, there's few things I thought about > maybe taking a step further (and one thing I'd prefer was taken a step back 😃) @szegedi Please review again ------------- PR Comment: https://git.openjdk.org/jdk/pull/22152#issuecomment-2491923569
