On Tue, 19 Nov 2024 22:31:28 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes 
> in the tests. Replace them with stubs.
> 
> Stop referencing IOUtils class from XmlUtils and PathUtils classes.

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line 220:

> 218:         String appImage = getArgumentValue("--app-image");
> 219:         if (appImage != null) {
> 220:             String name =  
> AppImageFile.load(Path.of(appImage)).mainLauncherName();

Suggestion:

            String name = 
AppImageFile.load(Path.of(appImage)).mainLauncherName();

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22261#discussion_r1851452856

Reply via email to