On Tue, 3 Sep 2024 19:51:39 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Also include information about where generated data is consumed. >> - Document how and why we keep track of native libraries per module > > make/ModuleWrapper.gmk line 59: > >> 57: endif >> 58: endif >> 59: > > This part looks a bit convoluted. It would be nice with a comment explaining > what it does, where `$($(MODULE)_JDK_LIBS)` is coming from and what consumes > the module-libs.txt. Fixed. > make/common/JdkNativeCompilation.gmk line 310: > >> 308: $$(MODULE)_JDK_LIBS += $$($1_NAME) >> 309: endif >> 310: endif > > Same, here as in ModuleWrapper.gmk, I think we need a comment explaining how > this is consumed. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1846394969 PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1846398235
