On Fri, 15 Nov 2024 01:12:00 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> Maybe move this code into switch statement under default? Can't use "null" in the switch. > should we use TypeStatus.UNKNOWN instead of null? To deal with `TypeStatus.UNKNOWN` and `null`? Besides of that what is the semantics of `TypeStatus.UNKNOWN`? - `TypeStatus.NOT_TEST_CLASS` is for types that are NOT test classes. - `TypeStatus.VALID_TEST_CLASS` is for types that are valid test classes. - `TypeStatus.TEST_CLASS` is for all other types, i.e. invalid test classes. How does `TypeStatus.UNKNOWN` fit? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21996#discussion_r1843949327
