On Thu, 7 Nov 2024 14:34:23 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits since the last revision:
>>
>> - update tests to match the new specification
>> - Stuart's review - update the close() and end() expectations
>> - Stuart's review - improve class level javadoc
>> - merge latest from master branch
>> - merge latest from master branch
>> - Chen's suggestion - improve code comment
>> - convert the tests to junit
>> - fix whitespace
>> - 8225763: Inflater and Deflater should implement AutoCloseable
>
> src/java.base/share/classes/java/util/zip/Inflater.java line 719:
>
>> 717: */
>> 718: @Override
>> 719: public void close() {
>
> Ditto, should this be `final` to be clear about what should be overridden to
> perform cleanup.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19675#discussion_r1843608174
