On Thu, 14 Nov 2024 04:59:48 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Hello Roger, I think that's a good idea. At least until there is a real >> reason for `close()` to be overridden by subclasses. I went back and checked >> the mailing list discussions (linked in this PR description) and I don't >> think marking `close()` as `final` has been suggested or rejected before. I >> will give others a chance to provide their inputs before I do this change. > > I agree with marking these close methods as final as long as the previous > corpus search did not find any user-defined close method in subclasses. Hello Chen, corpus analysis shows that there are no subclasses of Inflater/Deflater which have a `close()` method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19675#discussion_r1842137395
