On Wed, 13 Nov 2024 15:35:42 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), >> Serialization implementation dependencies on SecurityManager, doPrivildged, >> and AccessController are removed. >> Some refactoring to cleanup the remaining code is expected. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Remove unused imports Looks good other than 2 small comments. src/java.base/share/classes/java/io/ObjectInputStream.java line 281: > 279: * throwing {@link ClassNotFoundException}. > 280: */ > 281: private static final boolean GETFIELD_CNFE_RETURNS_NULL = > Boolean.getBoolean("jdk.serialGetFieldCnfeReturnsNull"); Nit: a bit of a long line, suggest breaking in two lines. ------------- Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22041#pullrequestreview-2436176284 PR Review Comment: https://git.openjdk.org/jdk/pull/22041#discussion_r1842276926