On Wed, 13 Nov 2024 16:01:54 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> This is used down below on line 423: >> >> >> private static boolean hasDefaultOrNoSerialization(Class<?> cl) { >> return ! Serializable.class.isAssignableFrom(cl) >> || cl.isInterface() >> || cl.isArray() >> || Proxy.isProxyClass(cl) // <=== right here >> || Externalizable.class.isAssignableFrom(cl) >> || cl.isEnum() >> || cl.isRecord() >> || cl.isHidden() >> || nonSerializableLeafClasses.contains(cl); >> } > > Sorry, I meant to flag PrivilegedAction. Ah, I see. It looks like it's still used though, in `GetReflectionFactoryAction` which hasn't been removed yet. I guess it'll be removed in one of the sub-tasks of [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411)? It wasn't added in this PR in any event. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19702#discussion_r1840724748