On Wed, 13 Nov 2024 14:13:59 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary suppress warnings removal
>> ServiceLoader configuration exceptions (in a static initialization) are
>> rethrown as Error.
>> Remove dependency on SecurityException thrown by ServiceLoader (as
>> obsolete)
>
> src/java.base/share/classes/java/time/zone/ZoneRulesProvider.java line 1:
>
>> 1: /*
>
> Lines 171-172:
>
> if (ex.getCause() instanceof SecurityException) {
> continue; // ignore the security exception, try the next
> provider
> }
>
> You may be able to remove this code, but may be better to leave it as-is for
> now until the SL code has been checked for cleanup.
The SL changes are in JDK-8344011.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22042#discussion_r1840444817
