On Fri, 8 Nov 2024 23:57:58 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
> The PR affects jpackage test library only. Changes: > > - Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is > still used as there is no better alternative. > - Use `TKit.concatMessages()` instead of `String.format()` in > TKit.assert...() methods. > - Added unit tests for all TKit.assert...() modified methods. > - Added unit tests for `JavaAppDesc` class. > - Added `jdk.jpackage.test.TestSuite` class to automatically run all jpackage > test library unit tests. This eliminates the need to add jtreg comments to > every jpackage test library unit test java source. @sashamatveev ptal test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaAppDesc.java line 178: > 176: return Objects.equals(this.srcJavaPath, other.srcJavaPath); > 177: } > 178: Netbeans generated code ------------- PR Comment: https://git.openjdk.org/jdk/pull/21995#issuecomment-2471725192 PR Review Comment: https://git.openjdk.org/jdk/pull/21995#discussion_r1835169118
