On Wed, 6 Nov 2024 21:24:14 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> @kimbarrett I added this to https://bugs.openjdk.org/browse/JDK-8343703. You >> are not as explicit here as the other places you commented that it is okay >> to do as a follow-up, but I'll assume that was what you meant. If not, let >> me know, and I'll look at fixing it for this PR already. > > The first part, eliminating the (IMO not actually helpful) helper function, I > wanted done here. The second part, > cleaning up or commenting the calculation of the length and dealing with > perhaps unneeded conditionals, I'm > okay with being in a followup. I guess I can live with the first part being > in that followup too. Ok, fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1834182702
