On Tue, 5 Nov 2024 14:07:12 GMT, Quan Anh Mai <qa...@openjdk.org> wrote:
>> Hi, >> >> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness >> check of non-closeable scopes such as the global scope can be elided. >> >> Currently, the `state` field is overloaded with 2 responsibilities, to act >> as a communication device between `close` and `checkValidState`, as well as >> a communication device between `close`, `acquire`, and `release`. This patch >> separates those concerns into `state` and `acquireCount`, allowing `state` >> to be marked as `@Stable`. >> >> With the patch, in `MemorySegmentGetUnsafe`, `panama` is able to be on par >> with `unsafe`: >> >> Benchmark Mode Cnt Score Error Units >> MemorySegmentGetUnsafe.panama avgt 30 0.340 ± 0.008 ns/op >> MemorySegmentGetUnsafe.unsafe avgt 30 0.332 ± 0.004 ns/op >> >> For reference this is the results without this patch: >> >> Benchmark Mode Cnt Score Error Units >> MemorySegmentGetUnsafe.panama avgt 30 0.420 ± 0.019 ns/op >> MemorySegmentGetUnsafe.unsafe avgt 30 0.329 ± 0.003 ns/op >> >> Please kindly review, thanks very much. > > Quan Anh Mai has updated the pull request incrementally with two additional > commits since the last revision: > > - copyright year > - address reviews Thanks a lot for your reviews and suggestions, I will merge this patch. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21810#issuecomment-2457920466
