On Mon, 4 Nov 2024 18:22:42 GMT, Patricio Chilano Mateo <pchilanom...@openjdk.org> wrote:
>> Note that `frame::sender_sp_offset` is 0 instead of 2 on linux-riscv64, >> which is different from aarch64 or x86-64. So I think we should revert this >> change: >> https://github.com/openjdk/jdk/pull/21565/commits/12213a70c1cf0639555f0f302237fd012549c4dd. >> @pchilano : Could you please help do that? >> >> (PS: `hotspot_loom & jdk_loom` still test good with latest version after >> locally reverting >> https://github.com/openjdk/jdk/pull/21565/commits/12213a70c1cf0639555f0f302237fd012549c4dd) > > Sorry, I also thought it matched the aarch64 one without checking. @RealFYang > should I change it for `hf.sp() + frame::link_offset` or just leave it as it > was? > Also, does this mean that the changes from 2 to frame::sender_sp_offset in > all of the lines (267, 271 and 273) should be reverted? > I think the previous lines are okay because we are constructing the fp, whereas in here we want to read the old fp stored in this frame. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1828191725
