On Sat, 2 Nov 2024 00:27:52 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reuse the check implementation
>
> src/java.base/share/classes/jdk/internal/constant/ConstantUtils.java line 191:
>
>> 189: * @throws NullPointerException if name is {@code null}
>> 190: */
>> 191: private static String validatePathBasedName(String name, boolean
>> usesSlash, boolean allowsEmpty) {
>
> Suggestion:
>
> private static String validatePackageOrClassName(String name, boolean
> internalName, boolean allowEmpty) {
Done. Seems skara bot doesn't recognize your review sent after I pushed my
rename unfortunately.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21830#discussion_r1826433516
