On Fri, 1 Nov 2024 01:53:01 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - add comment to ThreadService::find_deadlocks_at_safepoint
>> - Remove assignments in preempt_kind enum
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 889:
>
>> 887: return f.is_native_frame() ? recurse_freeze_native_frame(f, caller)
>> : recurse_freeze_stub_frame(f, caller);
>> 888: } else {
>> 889: // frame can't be freezed. Most likely the call_stub or upcall_stub
>
> Suggestion:
>
> // Frame can't be frozen. Most likely the call_stub or upcall_stub
Fixed.
> src/hotspot/share/services/threadService.cpp line 467:
>
>> 465: if (waitingToLockMonitor->has_owner()) {
>> 466: currentThread = Threads::owning_thread_from_monitor(t_list,
>> waitingToLockMonitor);
>> 467: // If currentThread is nullptr we would like to know if the
>> owner
>
> Suggestion:
>
> // If currentThread is null we would like to know if the owner
Fixed.
> src/hotspot/share/services/threadService.cpp line 474:
>
>> 472: // vthread we never record this as a deadlock. Note: unless
>> there
>> 473: // is a bug in the VM, or a thread exits without releasing
>> monitors
>> 474: // acquired through JNI, nullptr should imply unmounted
>> vthread owner.
>
> Suggestion:
>
> // acquired through JNI, null should imply an unmounted vthread
> owner.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1826154797
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1826155159
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1826155815
