On Fri, 1 Nov 2024 15:51:10 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I get a review for this patch that adds `@since` checker tests to the >> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. >> The initial test for `java.base` has been integrated in >> [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). >> >> The jtreg comments are almost the same as the ones for the `java.base` test, >> only the Bug ID and the module name being passed to the test are different. >> >> I've made a small change to `test/jdk/TEST.groups` to include the new tests. >> >> Here are the emails >> [[1](https://mail.openjdk.org/pipermail/jdk-dev/2024-June/009160.html)] >> [[2](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html)] >> in `jdk-dev` describing how the tests work and how to run them. >> >> TIA > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - remove redundant line > - Merge remote-tracking branch 'upstream/master' into since-checks-langtools > - fix test summary, add jshell module > - Add since checker tests to other modules Why are some test and the test for java.base in modules subdirectory, while some other jdk. module tests are not? Like `test/jdk/tools/sincechecker/modules/java_compiler/CheckSince_javaCompiler.java` vs `test/jdk/tools/sincechecker/jdk_compiler/CheckSince_jdkCompiler.java` (note `jdk_compiler` is not the a `modules` directory) ------------- PR Comment: https://git.openjdk.org/jdk/pull/21542#issuecomment-2452292014
