On Thu, 31 Oct 2024 13:29:35 GMT, Claes Redestad <redes...@openjdk.org> wrote:
> Benchmarks using Indify was added to the JMH microbenchmarks corpus in the > JDK 8 timeframe. This adds overhead to the microbenchmarks build and has been > blocking/slowing progress on some indy-based prototyping as the indify tool > itself may not be 100% forward compatible. > > I suggest we remove the Indify pass from the OpenJDK JMH test module and > remove the microbenchmarks which depend on the tool. > > These microbenchmarks will still available to build and run out of the > standalone https://github.com/openjdk/jmh-jdk-microbenchmarks project: > > https://github.com/openjdk/jmh-jdk-microbenchmarks/blob/master/micros-jdk8/src/main/java/org/openjdk/bench/java/lang/invoke/CallSiteSetTarget.java > https://github.com/openjdk/jmh-jdk-microbenchmarks/blob/master/micros-jdk8/src/main/java/org/openjdk/bench/java/lang/invoke/CallSiteSetTargetSelf.java > https://github.com/openjdk/jmh-jdk-microbenchmarks/blob/master/micros-jdk8/src/main/java/org/openjdk/bench/java/lang/invoke/CallSiteStable.java Looks reasonable. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21807#pullrequestreview-2408056984
