On Tue, 29 Oct 2024 20:57:48 GMT, Dean Long <dl...@openjdk.org> wrote:

>> No, it just happens to be stored at the sender_sp marker. We were already 
>> making room for two words but only using one.
>
> `sender_sp_offset` is listed under "All frames", but I guess that's wrong and 
> should be changed.  Can we fix the comments to match x86, which lists this 
> offset under "non-interpreter frames"?

I think aarch64 is the correct one. For interpreter frames we also have a 
sender_sp() that we get through that offset value: 
https://github.com/openjdk/jdk/blob/7404ddf24a162cff445cd0a26aec446461988bc8/src/hotspot/cpu/x86/frame_x86.cpp#L458
I think the confusion is because we also have 
interpreter_frame_sender_sp_offset where we store the unextended sp.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1823495787

Reply via email to