On Mon, 28 Oct 2024 20:10:16 GMT, Dean Long <dl...@openjdk.org> wrote:
>> It's the offset of the mirror passed to static native calls. It pre-existed >> saving the mirror in all frames to keep the Method alive, and is duplicated. >> I think this could be cleaned up someday, which would remove this special >> case. > > I tried to track down how interpreter_frame_num_oops() is used, and as far as > I can tell, it is only used to compare against the bitmap in debug/verify > code. So if this slot was added here, shouldn't there be a corresponding > change for the bitmap? When creating the bitmap, processing oops in an interpreter frame is done with `frame::oops_interpreted_do()` which already counts this extra oop for native methods. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1819757374