On Fri, 25 Oct 2024 21:57:01 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Object::wait
>
> src/hotspot/share/interpreter/oopMapCache.cpp line 268:
>
>> 266: }
>> 267:
>> 268: int num_oops() { return _num_oops; }
>
> I can't find what uses this from OopMapCacheEntry.
It's needed for verification in VerifyStackChunkFrameClosure. It's called in
OopMapCacheEntry::fill_for_native(), and we get there from here:
https://github.com/openjdk/jdk/blob/66d5385f8a1c84e73cdbf385239089a7a9932a9e/src/hotspot/cpu/x86/stackChunkFrameStream_x86.inline.hpp#L114
> src/hotspot/share/runtime/objectMonitor.hpp line 71:
>
>> 69: bool is_wait() { return _is_wait; }
>> 70: bool notified() { return _notified; }
>> 71: bool at_reenter() { return _at_reenter; }
>
> should these be const member functions?
Yes, changed to const.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1819462987
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1819463958
