On Thu, 24 Oct 2024 16:48:38 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Jonathan Lampérth has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - adress feedback in implementation >> - address feedback in tests > > I think I prefer your idea of keeping the code inside `CodeWriter`. > > Maybe have a `write` and a `writeVerbose`, and have a private method with a > `boolean` param that controls printing of extra info? @JornVernee > I think I prefer your idea of keeping the code inside `CodeWriter`. > > Maybe have a `write` and a `writeVerbose`, and have a private method with a > `boolean` param that controls printing of extra info? Not sure about the wording of using `writeVerbose`. It just happens that in the case when the `-verbose` flag is set, that `task.options.showAllAttrs = true;` is set, which leads to writing out the "complete" output of the `CodeWriter`. I think the non-verbose case is the exception, where we override the default `write` functionality. Thus I have opted for keeping the functionality and naming of `write` and adding a new function `writeMinimal` as the "non-standard" case. What do you think? ------------- PR Comment: https://git.openjdk.org/jdk/pull/21685#issuecomment-2437425971
