On Thu, 24 Oct 2024 14:07:34 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> @PaulSandoz do you think this is sufficient coverage? > > Please note this test was added just to cover scalar operation validation in > VectorMath, automated tests exercise these APIs in fallback implementation > anyways. I think the coverage is sufficient for now and we can expand later. The test is written so that it should be possible to more easily refactor and add further dynamically generated test cases. (Note it is deliberately not a test designed to specifically exercise C2 - if/when we add auto vectorization IR tests would be required). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1815191672
