On Wed, 23 Oct 2024 12:53:12 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> src/hotspot/share/prims/jvm.cpp line 1272:
>>
>>> 1270:
>>> 1271:
>>> 1272: // Returns the inherited_access_control_context field of the running
>>> thread.
>>
>> There's some code in this file in
>> static void trace_class_resolution_impl(Klass* to_class, TRAPS) {
>>
>> That does this:
>>
>>
>> while (!vfst.at_end()) {
>> Method* m = vfst.method();
>> if
>> (!vfst.method()->method_holder()->is_subclass_of(vmClasses::ClassLoader_klass())&&
>>
>> !vfst.method()->method_holder()->is_subclass_of(access_controller_klass) &&
>>
>> !vfst.method()->method_holder()->is_subclass_of(privileged_action_klass)) {
>> break;
>> }
>> last_caller = m;
>> vfst.next();
>> }
>>
>>
>> Is this dead code that should be removed?
>
> This tracing skips ClassLoader frames, you'll continue to see these when
> using Class.forName.
but you won't see access_controller_klass or priviledged_action_klass frames,
so no need to skip them? Not sure why you'd want to skip class loader frames
here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1813400810
