On Wed, 9 Oct 2024 10:40:53 GMT, Alan Bateman <al...@openjdk.org> wrote:
>>> @AlanBateman Can you please review [the CSR >>> request](https://bugs.openjdk.org/browse/JDK-8341596) so I can finish it? >>> Thanks! >> >> Latest API docs looks good, will you update the CSR? > >> @AlanBateman WDYT? > > A title like "Add Reader.of(CharSequence)" would make it clear to everyone > what this issue, and the CSR, is about. > @AlanBateman As the CSR is approved, kindly asking for your review of this PR > to finally integrate the changes. Thanks. I suggested this factory method so my interest/focus has been in its specification, I have not had cycles to look at the implementation or tests but you've got plenty of eyes on it. Minor edits would be make "The reader is initially .." the second sentence of the first paragraph rather than a new paragraph. Also "The returned reader supports the mark and reset ..." could move up to become the second paragraph. Otherwise happy that this ended up a static factory method rather than a new implementation class in the API. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21371#issuecomment-2431153332
