Re: RFR: 8233451: (fs) Files.newInputStream() cannot be used with character special files [v4]

[Brian Burkhalter]

On Tue, 22 Oct 2024 10:15:01 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8233451: Add tests for read{All,N}Bytes
>
> test/jdk/java/nio/file/Files/InputStreamTest.java line 29:
> 
>> 27:  * @library .. /test/lib
>> 28:  * @build jdk.test.lib.Platform
>> 29:  * @run junit InputStreamTest
> 
> I think this will need --enable-native-access=ALL-UNNAMED.

It works as is in the CI.

> test/jdk/java/nio/file/Files/InputStreamTest.java line 99:
> 
>> 97:                     try {
>> 98:                         try (FileOutputStream fos = new 
>> FileOutputStream(PIPE);)
>> 99:                         {
> 
> The formatting is a bit messed up, I think a previous iteration has a second 
> resource that is now removed.

Thanks, I'll clean it up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21508#discussion_r1811008472
PR Review Comment: https://git.openjdk.org/jdk/pull/21508#discussion_r1811009366