On Fri, 18 Oct 2024 20:38:31 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> test/jdk/java/util/zip/ZipEntry/MaxZipEntryFieldSizeTest.java line 28: >> >>> 26: * @summary Verify that ZipEntry(String), ZipEntry::setComment, and >>> 27: * ZipEntry::setExtra throws a IllegalArgumentException when the >>> 28: * combined length of the fields, including the size of the CEN Header, >> >> A test where the combined length exceeds the limit, but no one field alone >> exceeds the limit would be a nice addition. > > I am going to leat the comment as is Sorry, this was not to comment the summary, just pointing out that we have no test verifying the combined length exceeding the limit when each component alone does not. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21544#discussion_r1806999256
