On Thu, 17 Oct 2024 10:44:51 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Please review the changes for >> [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a >> follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) >> which addresses that >> >> - ZipEntry(String) >> - ZipEntry::setComment >> - ZipEntry::setExtra >> >> currently validate that the max possiible field size is 0xFFFF(65535) >> instead of 0xFFD1(65489) not taking into account the size of the CEN header >> which is 46 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12 >> >> The CSR has been approved. >> Mach5 tiers1-3 run clean as do the relevant JCK tests > > Lance Andersen has updated the pull request incrementally with one additional > commit since the last revision: > > Add back missing putNextEntry call test/jdk/java/util/zip/ZipOutputStream/ZipOutputStreamMaxCenHdrTest.java line 73: > 71: static final String ENTRY_COMMENT = "A Comment"; > 72: // Max length minus the size of the ENTRY_NAME or ENTRY_COMMENT > 73: static final int MAX_FIElD_LEN_MINUS_ENTRY_NAME = The "l" in "FIElD" seems lowercase? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21544#discussion_r1804611083
