On Wed, 16 Oct 2024 17:01:38 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> No issue from me on moving the notifications to the run method. My comment >> was more for the JvmtiMountTransition's class description as it's not easy >> to audit the use of this annotation. > > Got it, thanks. The updated changes to VirtualThread look fine. I'm still wondering about JvmtiMountTransition's class description. There's nothing obvious in yield and yield0 that they start/end a VTMS. Maybe for a future PR but I think the description could be expanded as the same questions will come up each time that anything using this annotation changes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1804553428
