On Sun, 13 Oct 2024 01:42:38 GMT, Shaojin Wen <s...@openjdk.org> wrote:
> This is a code style improvement for imports in the java/lang/classfile and > jdk/internal/classfile/impl directories, includes: > 1. Import in alphabetical order > 2. Add a blank line between java and jdk imports > 3. Use import * for a large number of imports Changes requested by liach (Reviewer). src/java.base/share/classes/jdk/internal/classfile/impl/verifier/VerifierImpl.java line 40: > 38: import > jdk.internal.classfile.impl.verifier.VerificationWrapper.ConstantPoolWrapper; > 39: > 40: import static jdk.internal.classfile.impl.RawBytecodeHelper.ILLEGAL; Suggestion: import static jdk.internal.classfile.impl.RawBytecodeHelper.*; This is using raw opcode from `RawBytecodeHelper` ------------- PR Review: https://git.openjdk.org/jdk/pull/21482#pullrequestreview-2372351160 PR Review Comment: https://git.openjdk.org/jdk/pull/21482#discussion_r1803032811
