On Tue, 15 Oct 2024 10:17:40 GMT, Emanuel Peter <epe...@openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update adlc changes.
>
> src/hotspot/share/opto/vectornode.hpp line 161:
> 
>> 159:   // Needed for proper cloning.
>> 160:   virtual uint size_of() const { return sizeof(*this); }
>> 161:   bool is_unsigned() { return _is_unsigned; }
> 
> Can you put this in the `print_spec`, so the IR dump shows if it is unsigned?

Hi @eme64 , I see print_spec is mainly used for dumping information about 
VTransformVectorNode,  please note newly added situating operations are not 
being auto-vectorized and are are emitted through VectorAPI based explicit 
vectorization flow.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1802382779

Reply via email to