On Thu, 10 Oct 2024 04:36:58 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - assertThrows instead of expectedExceptions >> - ordered jtreg tags according recommendation in >> https://openjdk.org/jtreg/tag-spec.html#ORDER > > src/java.base/share/classes/java/io/StringReader.java line 38: > >> 36: * {@code Reader.of(String)} should generally be used in preference to >> this one, >> 37: * as it supports all of the same operations but it is faster, as it >> performs no >> 38: * synchronization. > > We shouldn't using "release 24" or "supplemented" here. The API note just > needs to `Reader.of(CharSequence)` provides a method to read from any > CharSequence that may be more efficient than `StringReader`. I think "release 24" is fine for now as similar text exists in `java.util.Vector`. We can normalize such texts when we implement https://bugs.openjdk.org/browse/JDK-8341736. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1794650465
