On Fri, 31 May 2024 18:33:39 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >> A couple key things we want to be able to say are: >> - `Reference.reachabilityFence(x)` _happens-before_ reference processing >> occurs for 'x'. >> - `Cleaner.register()` _happens-before_ the Cleaner thread runs the >> registered cleaning action. >> >> This will bring Cleaner in line (or close) with the memory visibility >> guarantees made for finalizers in [JLS >> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5): >> _"There is a happens-before edge from the end of a constructor of an object >> to the start of a finalizer (ยง12.6) for that object."_ > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > another package doc link src/java.base/share/classes/java/lang/ref/Reference.java line 561: > 559: * triggering garbage collection. This method is applicable only > 560: * when reclamation may have visible effects, > 561: * such as for objects that use finalizers or {@link Cleaner}, or > code that This `@link` tag [does not produce a link in the Javadoc](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/ref/Reference.html#reachabilityFence(java.lang.Object)) because this file imports `jdk.internal.ref.Cleaner`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1794411907
