On Tue, 8 Oct 2024 22:51:46 GMT, Shaojin Wen <s...@openjdk.org> wrote:
>> Indeed, the opcode here is pointless if we have a pool adaption; in that >> case we should just use `ldc(LoadableConstantEntry)`. > > Here in writeLoadConstant, some branches have curly braces, and some don't. > The style is inconsistent. Should I change it? I think we can do it in a later cleanup that fixes writeLoadConstant. This patch is already huge. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21243#discussion_r1792606829
