> Can I please get a review for this patch which proposes to implement the > enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970? > > Edit: This PR description has now been updated to match the changes that were > done over the course of review inputs that were received for this enhancement. > > The commit in this PR introduces the ability to use `jar` tool to extract the > contents of the JAR file to a specific directory of choice. Optional `-C` and > `--dir` options are added to the `-x` main operation of the jar tool. The > value for these options is expected to be a file path which is expected to be > a directory to which the jar will be extracted. When neither `-C` nor `--dir` > are used, the extract operation of the jar tool will continue to behave like > it did before this enhancement and will extract the jar into the current > working directory. > > The commit also includes a jtreg testcase which verifies the usage of this > new option.
Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision: - use a fixed locale in the test to prevent failures on environments that are not en_US - add a test to verify extraction to a non-directory fails ------------- Changes: - all: https://git.openjdk.org/jdk/pull/2752/files - new: https://git.openjdk.org/jdk/pull/2752/files/73f6d6e7..0b8d5aaa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=2752&range=12 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=2752&range=11-12 Stats: 24 lines in 1 file changed: 23 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/2752.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/2752/head:pull/2752 PR: https://git.openjdk.org/jdk/pull/2752
