On Thu, 3 Oct 2024 13:15:10 GMT, Shaojin Wen <s...@openjdk.org> wrote:

>> 1. Construct Frames directly without BitSet
>> 2. Use Frame[] instead of ArrayList
>> 3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects 
>> when there is no frame.
>
> Shaojin Wen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reduce codeSize

src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java 
line 852:

> 850:     /**
> 851:      * Performs detection of mandatory stack map frames in a single 
> bytecode traversing pass
> 852:      * @return detected frames

`@return` on `void` method:
Suggestion:

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21183#discussion_r1786788792

Reply via email to