On Wed, 2 Oct 2024 20:32:57 GMT, Alexander Matveev <almat...@openjdk.org> wrote:

> - `AppContentTest` and `SigningOptionsTest` failed on macOS 15 due to 
> `codesign` no longer fails if additional content is added to app image.
> - `SigningOptionsTest` fixed by failing `codesign` due to missing identity, 
> since we only need to check that warning message is displayed when codesign 
> fails and `--app-content` is specified.
> - `AppContentTest` is fixed by setting expected exit code based on macOS 
> version.

Marked as reviewed by asemenyuk (Reviewer).

Looks good

-------------

PR Review: https://git.openjdk.org/jdk/pull/21313#pullrequestreview-2344071580
PR Comment: https://git.openjdk.org/jdk/pull/21313#issuecomment-2389662348

Reply via email to