On Tue, 1 Oct 2024 08:20:43 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> `jni_md.h` is shipped as part of every JDK distribution - this change does >> NOT belong in that file. > >> `jni_md.h` is shipped as part of every JDK distribution - this change does >> NOT belong in that file. > > Hi David, should I introduce a separate ub.hpp (similar to what we have in > Hotspot) ? > @MBaesken my understanding is that src/java.base/share/native/include is for > exported header files, it is not a general location to put this new header. Seems the include directories src/java.base/unix/native/libjava and also hotspot/os/posix/include and src/hotspot/share/include show up in the '-I' settings of these C compilation units in jdk. And from what I see those are not exported Should I move the header to some of these ? Putting it into some hotspot location sounds odd because we have already 'sanitizers/ub.hpp' in hotspot. So maybe src/java.base/unix/native/libjava ? ------------- PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2387849588
