On Tue, 1 Oct 2024 14:10:04 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright > > test/micro/org/openjdk/bench/java/lang/foreign/LoopOverNonConstantAsType.java > line 103: > >> 101: } >> 102: >> 103: @CompilerControl(CompilerControl.Mode.DONT_INLINE) > > I think the intent was to block inlining of `asType`, so it gets compiled in > isolation? That should be done with a `CompileCommand` though. This > annotation just blocks inlining of `compileAsType` AFAIK. I see what you mean... I'll do some experiments and see how the current annotation affects the benchmark - if at all. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21283#discussion_r1783112144
