On Mon, 30 Sep 2024 14:29:03 GMT, sbgoog <d...@openjdk.org> wrote:
>> In which case the code might be simplified to just:
>>
>> } catch (InterruptedException e) {
>> // Don't lose the interrupt
>> Thread.currentThread().interrupt();
>> break;
>> }
>
> I've reworked the change to always set the interrupted status. I wouldn't
> remove the check of the error code here, as it'd be a behavior change. I can
> follow up with that, though it seems to me that it's good to still have the
> check for access error here.
My suggestion was to `break;` instead of `return false;` which would fall
through to line 967 where the check method would be called. But what you have
is probably preferable as it preserves the original style and keep the changes
minimal.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20938#discussion_r1781313496
